Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#3013 closed enhancement (fixed)

Should use jQuery to check classes

Reported by: kayue's profile kayue Owned by:
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Templates Keywords: jquery, js
Cc:

Description

in defualt_theme/_inc/global.js , line 315

if ( 'activity-comments' !== form_parent.attr('class') ) {

should be written as

if ( !form_parent.hasClass('activity-comments') ) {

The reason for this is to avoid javascript from malfunctioning after people like me add an additional class.

Change History (3)

#1 @DJPaul
13 years ago

  • Milestone changed from Awaiting Review to 1.3
  • Type changed from task to enhancement

#2 @djpaul
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3812]) Improve javascript class checks. Fixes #3013

#3 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.