Skip to:
Content

BuddyPress.org

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#1060 closed defect (bug) (fixed)

bp_forums_get_topic_details should get topic meta so bp template tags work

Reported by: junsuijin's profile junsuijin Owned by: junsuijin's profile junsuijin
Milestone: 1.1 Priority: minor
Severity: Version:
Component: Keywords: has-patch, tested
Cc:

Description

bp_forums_get_topic_details does not get the topic meta, due to some strange effect of bbPress' bb_append_meta i think. I'm unable to track exactly why this doesn't work as expected using bbPress' get_topic. The given patch allows for bp_forums_get_topic_details to get the topic meta along with the other topic details, setting up a topic the same as bp_has_forum_topics does, and thus allowing the bp template tags like bp_the_topic_object_permalink to function properly.

Attachments (2)

fix-bp_forums_get_topic_details.patch (455 bytes) - added by junsuijin 15 years ago.
fix2-bp_forums_get_topic_details.patch (1.6 KB) - added by junsuijin 15 years ago.
tested various group pages for anything this might adversely affect; it seems clean

Download all attachments as: .zip

Change History (8)

#1 @junsuijin
15 years ago

  • Keywords has-patch added; has-patchm removed

#2 @apeatling
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [1936]) Fixes #1060 props junsuijin

#3 @junsuijin
15 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Found that this is still an issue on all singular group pages and group subpages. The provided patch fixes the issue by applying the group filters to the forum topic query (even when there is a current group in the bp global). It also handles the fact that adding those filters will still not return the necessary data for the actual current group.

@junsuijin
15 years ago

tested various group pages for anything this might adversely affect; it seems clean

#4 @apeatling
15 years ago

I don't want to add group specific code to the get_topic function since this will tie forums exclusively to groups (outside of the directory). Actually, the code in that function was not needed, the filter on the SQL just needed to apply to the group pages as well as the directory. Please test this fix.

#5 @apeatling
15 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [1974]) Fixes #1060

#6 @apeatling
15 years ago

As a side effect of this - you will only be able to select topics that are for that specific group. Selecting topics from other groups on a group page will result in NULL.

Note: See TracTickets for help on using tickets.