Ticket #1264 (closed defect: fixed)

Opened 11 months ago

Last modified 9 months ago

Comments on password protected/private blog posts showing on activity stream

Reported by: boonebgorges Owned by:
Priority: minor Milestone: 1.1.3
Component: Keywords: activity, dev-feedback
Cc:

Description

New blog posts that are either password protected or private are not posted to the BP activity streams. But comments on those posts are. I guess I'm not sure if this is a bug or not. In my own BP community, people assume that comments on hidden posts will also be hidden, and it's problematic when they show up.

I've attached a little patch that keeps comments on pw protected posts from showing up. I didn't include a fix for comments on private blogs, as I couldn't see at a glance where in the code private blog posts are filtered out.

Anyway, I hope someone can jump in and let me know whether this is the sort of thing that should be patched.

Attachments

password-protect-comments-out-of-activity.patch Download (476 bytes) - added by boonebgorges 11 months ago.

Change History

Changed 11 months ago by boonebgorges

Changed 11 months ago by DJPaul

I'd agree password protected posts shouldn't go on the site wide activity as everyone on the BP site probably won't be able to access them.

Private posts seem to be defined as "... visible only to you (and to other editors or admins within your site)." Not sure will be interested in what others think.

Changed 9 months ago by apeatling

  • milestone set to 1.1.3

Comments should not show in this circumstance, this should be fixed.

Changed 9 months ago by apeatling

  • status changed from new to closed
  • resolution set to fixed

(In [2115]) Don't record comments for password protected posts. Fixes #1264 props boonebgorges.

Note: See TracTickets for help on using tickets.